Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move amj keyboards into amjkeyboard vendor folder #15733

Merged
merged 3 commits into from
Apr 19, 2022
Merged

move amj keyboards into amjkeyboard vendor folder #15733

merged 3 commits into from
Apr 19, 2022

Conversation

peepeetee
Copy link
Contributor

@peepeetee peepeetee commented Jan 4, 2022 •
edited
Loading

Description

I discussed with @cj1324 and we decided to change the VID to A+M+J = 0x00D8

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

This was referenced Jan 4, 2022
Closed
Merged
@peepeetee
Copy link
Contributor Author

See #5945 for more information

@stale
Copy link

stale bot commented Apr 16, 2022

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@stale stale bot removed the awaiting changes label Apr 19, 2022
tzarc
tzarc approved these changes Apr 19, 2022
View reviewed changes
Copy link
Member

@tzarc tzarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed no collision with the supplied VID.

@tzarc tzarc requested a review from a team April 19, 2022 10:21
@drashna drashna requested a review from a team April 19, 2022 17:59
@tzarc tzarc merged commit bd8220e into qmk:develop Apr 19, 2022
0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
@peepeetee @tzarc @zykrah
move amj keyboards into amjkeyboard vendor folder (qmk#15733)
91ec3a7 
Co-authored-by: Nick Brassel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peepeetee @drashna @tzarc